-
Notifications
You must be signed in to change notification settings - Fork 163
Feature: OCPP server observability #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7a1d09a to
a624578
Compare
|
I'll need some help with this PR to capture metrics at points where it makes most sense and since Im not that familiar with the flows right now, Im open to suggestions. |
lorenzodonini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the great work. I think this is a very good start, we can fine-tune more metrics down the road and/or accept requests.
I recommend waiting to improve on this until #347 is merged, since it includes some structural changes in the websocket package. Sorry about that but it's been long due.
Hey, no problem! I'll wait for the PR to be merged, meanwhile I will address all the comments and add the missing error handling. What do you think about adding tracing? |
It's merged now, feel free to rebase. Sorry about the conflicts.
Both metric and tracing have on my TODO list for a while, so thanks for getting this started. If you wish to add tracing as well, I'd love it, but would recommend a separate PR for that. |
87af54b to
5723667
Compare
901d39a to
fa622e0
Compare
|
Since a lot of people have issues with the callback queue/reconnection, we should also probably add additional metrics for dispatcher and message queues. |
fa622e0 to
44085f8
Compare
|
@lorenzodonini mind rereviewing? I think the PR is good enough for an initial version/PoC, definitely need to add more server metrics. |
Proposed changes
Based on my feature request in #334, I added support for OCPP-J and Websocket server metrics.
Caution
Watch out for a breaking change: Go version updated to 1.22, because the OTel SDKs require at least 1.22.
OCPPJserver metricswebsocketmetricsdocker-composefiles for both TLS and non-tls examples so observability can be configuredmakefilecommands so deploying examples is easierTypes of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
List of things that should be noted/addressed in the future:
Havent added websocket request rate metric, which could be usefulPotential Tracing integration?Out of scope for nowDocumentation update