Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/method injectors #277

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Feature/method injectors #277

merged 3 commits into from
Aug 16, 2023

Conversation

pwelter34
Copy link
Member

  • removed GenerateDataReaderAttribute use TableAttribute
  • make FluentCommand.Dapper, FluentCommand.EntityFactory and FluentCommand.Batch obsolete
  • changed generated extension methods to be Query instead of QueryUser

@pwelter34
start work on injectors
cb9ae6e
@pwelter34
Delete AuditExtensions.cs
54b663a
@pwelter34
refactor generator
7251390 
- removed GenerateDataReaderAttribute use TableAttribute
- make FluentCommand.Dapper, FluentCommand.EntityFactory and FluentCommand.Batch obsolete
- changed generated extension methods to be Query<User> instead of QueryUser
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5874676055

  • 108 of 126 (85.71%) changed or added relevant lines in 6 files are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.5%) to 43.028%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/FluentCommand/DataQueryExtensions.cs 8 9 88.89%
src/FluentCommand.Generators/DataReaderFactoryGenerator.cs 0 2 0.0%
test/FluentCommand.SqlServer.Tests/DataCommandSqlTests.cs 0 5 0.0%
src/FluentCommand/DataReaderExtensions.cs 5 15 33.33%
Files with Coverage Reduction New Missed Lines %
src/FluentCommand.SqlServer/Merge/DataMergeDefinition.cs 1 72.73%
src/FluentCommand/QueryMultipleResult.cs 3 59.09%
src/FluentCommand/Internal/DataSequentialReader.cs 17 0%
Totals Coverage Status
Change from base Build 5812535745: 2.5%
Covered Lines: 2361
Relevant Lines: 5094
💛 - Coveralls

@pwelter34 pwelter34 merged commit dd57067 into master Aug 16, 2023
2 checks passed
@pwelter34 pwelter34 deleted the feature/method-injectors branch August 16, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwelter34 @coveralls