-
Notifications
You must be signed in to change notification settings - Fork 0
Adopt Podman Cloud Run deployment pattern #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
…tignore) Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
…uction docs: document prompt vault companion stack
…jectives FR#300: Strategic Gap Analysis for Prompt Vault Hackathon Alignment
…evpost Add comprehensive DevPost strategic audit and submission blueprint (FR#350)
Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
…test compatibility Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
…ons.md Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
…ions Set up modular Copilot instructions following GitHub best practices
Co-authored-by: stevei101 <287896+stevei101@users.noreply.github.com>
Apply PR #255: Fix backend test stability and Cloud Run compatibility
fix: restore backend test stability
…-vault feat: add us-central1 gar for prompt vault
Summary of ChangesHello @stevei101, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing and standardizing the project's deployment infrastructure and development tooling. By adopting a shared Podman Cloud Run deployment pattern via GitHub Actions, the project aims to achieve more consistent and efficient deployments for both its backend and frontend services. Concurrently, the documentation has been reorganized for better accessibility, and the frontend development environment has been streamlined by migrating to Bun as the sole package manager, enhancing developer experience and build performance. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adopts the podman-cloudrun-deploy-gha shared workflow, which is a great move for standardizing deployments. The reorganization of the documentation into deployment, integrations, and archive folders improves clarity, and the switch to bun for all frontend tooling is a welcome simplification. The code changes, including lint fixes and test updates, are well-executed.
My main concern, as detailed in a specific comment, is the removal of test suites that verified important security and deployment best practices for the FastAPI application and Docker configuration. While the CI-related tests have been updated appropriately, losing these other checks could introduce regressions in the future. I recommend reconsidering their removal.
Summary
Testing