Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fuzzing test #271

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Refactor fuzzing test #271

merged 3 commits into from
Mar 8, 2024

Conversation

Leeeon233
Copy link
Member

@Leeeon233 Leeeon233 commented Feb 22, 2024

This is a previous proposal, but the code has never been implemented.

Now use Map as an example.
There's a lot of redundant code and some inconsistencies in the current fuzzing tests, so I've introduced an additional abstract. The purpose of this is to:

  • Minimize boilerplate code.
  • Facilitate the extension of new semantic types, such as movable list, table, etc.
  • Simplify the extension and maintenance of common actions, like sync and checkout.

What are your suggestions?

TODO

  • new fuzz crate
  • add List Map Text and Tree in the new fuzz
  • add checking that deep value is equal

More ergonomic action and error output for debugging

@Leeeon233 Leeeon233 requested a review from zxch3n February 22, 2024 12:45
@zxch3n
Copy link
Member

zxch3n commented Feb 22, 2024

Can we move the fuzz code to a new crate like fuzz? I guess they don't need to rely on the internal stuff now, correct? It was inside loro-internal because we needed it to test some internal implementation back then. Then, we may remove the test_utils feature in the future. And we can now rely on loro instead of loro-internal.

@Leeeon233
Copy link
Member Author

Can we move the fuzz code to a new crate like fuzz? I guess they don't need to rely on the internal stuff now, correct?

I think so.

@Leeeon233 Leeeon233 self-assigned this Feb 23, 2024
@Leeeon233 Leeeon233 force-pushed the feat-better-fuzz branch 2 times, most recently from d2e3b1b to 831da99 Compare March 1, 2024 11:11
@Leeeon233 Leeeon233 marked this pull request as ready for review March 4, 2024 02:59
@zxch3n zxch3n merged commit a47cf06 into main Mar 8, 2024
1 check passed
@zxch3n zxch3n deleted the feat-better-fuzz branch March 8, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants