Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: state lock when emit events #272

Merged
merged 2 commits into from
Feb 25, 2024
Merged

fix: state lock when emit events #272

merged 2 commits into from
Feb 25, 2024

Conversation

Leeeon233
Copy link
Member

If any function that needs the lock of state is called in Subscriber, the deadlock will happen.

@Leeeon233 Leeeon233 requested a review from zxch3n February 23, 2024 12:13
@Leeeon233 Leeeon233 self-assigned this Feb 23, 2024
zxch3n
zxch3n reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@zxch3n zxch3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better to include the test case

@Leeeon233
Copy link
Member Author

It'd be better to include the test case

done

@Leeeon233 Leeeon233 merged commit 1f4a59e into main Feb 25, 2024
1 check passed
@Leeeon233 Leeeon233 deleted the fix-state-lock branch February 25, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxch3n zxch3n zxch3n approved these changes

Assignees

@Leeeon233 Leeeon233

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leeeon233 @zxch3n