fix missing event when checkout #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxch3n
approved these changes
Feb 29, 2024
Leeeon233
commented
Feb 29, 2024
| @@ -262,24 +262,15 @@ impl DiffCalculator { | |||
| InternalContainerDiff { | |||
| idx, | |||
| bring_back, | |||
| is_container_deleted: are_rest_containers_deleted, | |||
| is_container_deleted: false, | |||
There was a problem hiding this comment.
Don’t we need to determine this anymore?
There was a problem hiding this comment.
It seems like we don't need this field
There was a problem hiding this comment.
I'll test it in another branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the doc is attached, it uses the
diff_calcinLoroDoc, and the depth ofContainerDiffCalculatormay still be the old cached value. That causes thediff_calcto believe that the depth is inconsistent and the container may have been deleted. So we cannot receive the event.Maybe we should have a better way to determine whether the container is deleted.