feat: add options for proxy and host #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotem
reviewed
Mar 4, 2025
lotem
reviewed
Mar 4, 2025
lotem
reviewed
Mar 4, 2025
|
用env是最无痛传递全局参数的方式，否则从接口传递进去要很长的路径相当麻烦 后面想了下，其实确实没有必要去负担proxy 或者 repo host写错的情况，直接放过不检查regex匹配就行 限制在download和install里改成函数调用 用全局参数以便这些选项可以在处理子命令之前处理了，这样就可以放前或者放后都可以 应该算是解完了 |
|
用環境變量不行。我開始暴改。 |
|
改完代碼，我發現設置 |
lotem
added a commit
that referenced
this pull request
Mar 9, 2025
Closes #1 Squashed commit of the following: commit ae020da Author: fxliang <fx.liang@outlook.com> Date: Tue Mar 4 20:33:00 2025 +0800 simplify setup process of proxy and repo host commit cfaa1e3 Author: fxliang <fx.liang@outlook.com> Date: Tue Mar 4 12:38:00 2025 +0800 feat: set repo host with option `--host <host>` commit debfddb Author: fxliang <fx.liang@outlook.com> Date: Tue Mar 4 12:31:00 2025 +0800 feat: set proxy with option `--proxy <proxy>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.