Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lac favicon #100

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat: add lac favicon #100

merged 2 commits into from
Sep 10, 2024

Conversation

Aidosmf
Copy link
Member

@Aidosmf Aidosmf commented Sep 10, 2024 •
edited
Loading

An example:

Screenshot 2024-09-10 at 13 28 18

the old mkdocs version automatically picks up the new favicon file

@Aidosmf Aidosmf self-assigned this Sep 10, 2024
@mbasaglia
Copy link
Member

I think it should be placed in tools/theme/img since this is technically a theme override

@mbasaglia mbasaglia merged commit 51d85a2 into main Sep 10, 2024
6 checks passed
@Aidosmf Aidosmf deleted the mf/favicon branch October 22, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasaglia mbasaglia mbasaglia approved these changes

@b-wils b-wils b-wils approved these changes

@fmalita fmalita fmalita approved these changes

Assignees

@Aidosmf Aidosmf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aidosmf @mbasaglia @fmalita @b-wils