Add pucker/bloat modifier #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmalita
reviewed
Oct 8, 2024
| "$ref": "#/$defs/properties/scalar-property" | ||
| } | ||
| }, | ||
| "required": [ |
fmalita
reviewed
Oct 8, 2024
| {schema_object:shapes/pucker-bloat} | ||
|
|
||
| When `a` is `0`, nothing changes.<br/> | ||
| When `a` is positive, the vertices are pulled towards the center, with `100` being at the center. And the tangents are pushed away.<br/> |
There was a problem hiding this comment.
We should document what the center of an arbitrary shape is. IIRC it's the average of all vertices.
mbasaglia
added
Draft (RFC 2)
b-wils
approved these changes
Oct 15, 2024
fmalita
approved these changes
Oct 15, 2024
Aidosmf
approved these changes
Oct 22, 2024
|
@mbasaglia should we merge to a develop or version-specific branch? |
Not sure, we could also cherry pick on patch branches |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
mbasaglia
added
Accepted (RFC 3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a modifier to the specs, it's rather simple to implement and already supported by lottie-web.