Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stroke specs #26

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Add stroke specs #26

merged 3 commits into from
Apr 18, 2024

Conversation

mbasaglia
Copy link
Member

Adds stroke, the schema is split to add gradient stroke in the future without duplicating all the properties.

fmalita
fmalita approved these changes Apr 15, 2024
View reviewed changes
schema/shapes/base-stroke.json Show resolved Hide resolved
schema/shapes/stroke-dash.json Outdated Show resolved Hide resolved
Aidosmf
Aidosmf approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Aidosmf Aidosmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few questions

schema/shapes/base-stroke.json Show resolved Hide resolved
schema/shapes/stroke.json Show resolved Hide resolved
@mbasaglia @Aidosmf
Update schema/shapes/stroke.json
b686e76 
Co-authored-by: Aidos Sabit <aidosmf@gmail.com>
@mbasaglia mbasaglia merged commit 76b5617 into lottie:main Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aidosmf Aidosmf Aidosmf approved these changes

@fmalita fmalita fmalita approved these changes

@kudanai kudanai kudanai approved these changes

@b-wils b-wils Awaiting requested review from b-wils

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbasaglia @kudanai @fmalita @Aidosmf