Small schema fixes #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove `st` as required field on layer. This field was removed in lottie#53 2. Remove min/max on some gradient scalar properties. Scalar properties are objects and the values are in `k`, so min/max doesn't apply at that level. We would need to reach deeper into the object to properly apply limits. These were discovered using full strict mode on ajv. We may want to turn this on in our tests, however I was having some issues with cases where the property definition and required were split between if/then/allof etc.
|
Hopefully this should be fine to take during freeze as it is minor polishing, but let me know if there are any concerns. |
mbasaglia
approved these changes
Sep 6, 2024
| }, | ||
| "a": { | ||
| "title": "Highlight Angle", | ||
| "description": "Highlight Angle in clockwise degrees, relative to the direction from `s` to `e`", | ||
| "$ref": "#/$defs/properties/scalar-property", | ||
| "minimum": 0, | ||
| "maximum": 360 |
There was a problem hiding this comment.
Generally min/max range should be documented but I don't think either of these properties need to be clamped anyway
IMO it's fine |
Aidosmf
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stas required field on layer. This field was removed in Add some docs for layer time start and stretch #53k, so min/max doesn't apply at that level. We would need to reach deeper into the object to properly apply limits.These were discovered using full strict mode on ajv. We may want to turn this on in our tests, however I was having some issues with cases where the property definition and required were split between if/then/allof etc.