Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos #98

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix some typos #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/specs/constants.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@

{schema_string:constants/matte-mode/description}

The value for Luma is calculated accourding to [Rec.709](https://www.itu.int/rec/R-REC-BT.709) standard:
The value for Luma is calculated according to [Rec.709](https://www.itu.int/rec/R-REC-BT.709) standard:

$$Y = 0.2126 R + 0.7152 G + 0.0722 B$$

Expand Down
2 changes: 1 addition & 1 deletion docs/specs/helpers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ The operations need to be chained using right multiplication instead of left mul

Slots are a way to define a property value once and use the value in multiple
properties. Slot definitions are in a dictionary, the slot definition key is the
key that is used to match all properties with an `sid` field to the same key for
key that is used to match all properties with a `sid` field to the same key for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both these are valid depending on whether you say each letter individually or the whole thing as a single syllable 🤣 .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use ar in this case because r looks like half an n :P

replacement.

<h3 id="slot">Slot</h3>
Expand Down
5 changes: 3 additions & 2 deletions docs/specs/properties.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Their structure depends on whether it's animated or not:

Keyframe arrays MUST be stored in order of ascending `t` frame number.

Two consecutive keyframes MAY have the same `t` value but a property MUST NOT have more that two keyframes with the same `t`.
Two consecutive keyframes MAY have the same `t` value but a property MUST NOT have more than two keyframes with the same `t`.
If two keyframes share the `t` value, the implementation MUST render one of the two values at the given frame.

All keyframes MUST have an `i` and `o` value, unless-
Expand All @@ -26,7 +26,8 @@ All keyframes MUST have an `i` and `o` value, unless-
* `h` is present and it's 1, as the property will keep the same value until the
next keyframe.

If the first keyframe occurs after the start of the animation, the initial property value will be from the first keyframe. Similarly if the last keyframe is before the end of the animation, the last keyframe value will be held until the end.
If the first keyframe occurs after the start of the animation, the initial property value will be from the first keyframe.
Similarly, if the last keyframe is before the end of the animation, the last keyframe value will be held until the end.

<h3 id="easing-handle">Keyframe Easing</h3>

Expand Down
4 changes: 2 additions & 2 deletions docs/specs/shapes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ the instructions are equivalent to `value[0]` and `value[1]` respectively.
All paths MUST be closed unless specified otherwise in the rendering instructions.

When instructions call for an equality comparison between two values,
implementaions MAY consider similar values to be equal to overcome numerical instability.
implementations MAY consider similar values to be equal to overcome numerical instability.

### Drawing Commands

Expand All @@ -85,7 +85,7 @@ Drawing instructions will contain the following commands:
* _add vertex_: Adds a vertex to the bezier shape in global coordinates
* _set in tangent_: Sets the cubic tangent to the last added vertex, with coordinates relative to it. If omitted, tangents MUST be $(0, 0)$.
* _set out tangent_: Sets the cubic tangent from the last added vertex, with coordinates relative to it. If omitted, tangents MUST be $(0, 0)$.
* _lerp_: Linerarly interpolates two points or scalars by a given amount.
* _lerp_: Linearly interpolates two points or scalars by a given amount.


### Approximating Ellipses with Cubic Bezier
Expand Down
4 changes: 2 additions & 2 deletions docs/specs/values.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ second corresponding to the _Y_.

Colors are [Vectors](#vector) with values between 0 and 1 for the RGB components.

for example:
For example:

* {lottie_color:1, 0, 0}
* {lottie_color:1, 0.5, 0}

Note sometimes you might find color values with 4 components (the 4th being alpha)
Note: sometimes you might find color values with 4 components (the 4th being alpha)
but most players ignore the last component.

<h2 id="hexcolor">Hex Color</h2>
Expand Down
2 changes: 1 addition & 1 deletion schema/composition/animation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
},
"slots": {
"title": "Slots",
"description": "Dictionary of slot ids that that will replace matching properties.",
"description": "Dictionary of slot ids that will replace matching properties.",
"type": "object",
"additionalProperties": {
"$ref": "#/$defs/helpers/slot"
Expand Down
4 changes: 2 additions & 2 deletions schema/helpers/slottable-object.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"$schema": "https://json-schema.org/draft/2020-12/schema",
"type": "object",
"title": "Slottable Object",
"description": "Object that may have it's value replaced with a slot value",
"description": "Object that may have its value replaced with a slot value",
"properties": {
"sid": {
"title": "Slot Id",
"description": "Identifier to look up the slot",
"type": "string"
}
}
}
}
4 changes: 2 additions & 2 deletions schema/helpers/slottable-property.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://json-schema.org/draft/2020-12/schema",
"type": "object",
"title": "Slottable Property",
"description": "Property that may have it's value replaced with a slot value",
"description": "Property that may have its value replaced with a slot value",
"allOf": [
{
"$ref": "#/$defs/helpers/slottable-object"
Expand All @@ -14,4 +14,4 @@
"else": {
"required": ["a", "k"]
}
}
}
2 changes: 1 addition & 1 deletion schema/shapes/graphic-element.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://json-schema.org/draft/2020-12/schema",
"type": "object",
"title": "Graphic Element",
"description": "Element used to display vector daya in a shape layer",
"description": "Element used to display vector data in a shape layer",
"allOf": [
{
"$ref": "#/$defs/helpers/visual-object"
Expand Down
2 changes: 1 addition & 1 deletion schema/values/gradient.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://json-schema.org/draft/2020-12/schema",
"type": "array",
"title": "Gradient",
"description": "A flat list of color stops followed by optional transparency stops. A color stop is [offset, red, green, blue]. A transperency stop is [offset, transparency]. All values are between 0 and 1",
"description": "A flat list of color stops followed by optional transparency stops. A color stop is [offset, red, green, blue]. A transparency stop is [offset, transparency]. All values are between 0 and 1",
"items": {
"type": "number",
"minimum": 0,
Expand Down