Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slack] restructure alert actions, add 'visit site' button #3886

Merged
merged 15 commits into from
Apr 2, 2024
Merged

[Slack] restructure alert actions, add 'visit site' button #3886

Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c75a418
fix for #3351: restructure alert actions, add 'visit site' button
DaanMeijer Oct 13, 2023
69e9fce
added comments to code, restructured code to take into account not ha…
DaanMeijer Oct 13, 2023
ed85b95
fixd linting errors
DaanMeijer Oct 13, 2023
c7421ac
stylistic changes for review
DaanMeijer Oct 13, 2023
ec65ca4
Update server/notification-providers/slack.js
DaanMeijer Oct 14, 2023
42e0aed
Update server/notification-providers/slack.js
DaanMeijer Oct 14, 2023
b5ae9d9
Update server/notification-providers/slack.js
DaanMeijer Oct 14, 2023
46a088a
Update server/notification-providers/slack.js
DaanMeijer Oct 14, 2023
7be2de8
Update server/notification-providers/slack.js
DaanMeijer Oct 14, 2023
d0e6a11
Apply suggestions from code review
DaanMeijer Oct 14, 2023
535ce0b
fixed linter warnings/errors
DaanMeijer Oct 14, 2023
875b047
fixed linting errors
DaanMeijer Oct 14, 2023
e44f5b2
refactored block and action building to not be async
DaanMeijer Oct 14, 2023
9c7f817
commit to re-run the automated checks
DaanMeijer Oct 14, 2023
f94faa2
Apply suggestions from code review
DaanMeijer Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 69 additions & 40 deletions server/notification-providers/slack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,75 @@ class Slack extends NotificationProvider {
return okMsg;
}

const actions = [];
CommanderStorm marked this conversation as resolved.
Show resolved Hide resolved

const baseURL = await setting("primaryBaseURL");

if (baseURL) {
actions.push({
"type": "button",
"text": {
"type": "plain_text",
"text": "Visit Uptime Kuma",
},
"value": "Uptime-Kuma",
"url": baseURL + getMonitorRelativeURL(monitorJSON.id),
});

}

if (monitorJSON.url) {
actions.push({
"type": "button",
"text": {
"type": "plain_text",
"text": "Visit site",
},
"value": "Site",
"url": monitorJSON.url,
});
}

const textMsg = "Uptime Kuma Alert";

//create an array to dynamically add blocks
const blocks = [];
CommanderStorm marked this conversation as resolved.
Show resolved Hide resolved
CommanderStorm marked this conversation as resolved.
Show resolved Hide resolved

// the header block
blocks.push({
"type": "header",
"text": {
"type": "plain_text",
"text": textMsg,
},
});

// the body block, containing the details
blocks.push({
"type": "section",
"fields": [
{
"type": "mrkdwn",
"text": "*Message*\n" + msg,
},
{
"type": "mrkdwn",
"text": `*Time (${heartbeatJSON["timezone"]})*\n${heartbeatJSON["localDateTime"]}`,
}
],
});

//only add this block if we have actions
CommanderStorm marked this conversation as resolved.
Show resolved Hide resolved
if (actions.length > 0) {

CommanderStorm marked this conversation as resolved.
Show resolved Hide resolved
//the actions block, containing buttons
blocks.push({
"type": "actions",
"elements": actions,
});
}

//finally, build the entire slack request object
let data = {
"text": `${textMsg}\n${msg}`,
"channel": notification.slackchannel,
Expand All @@ -58,26 +126,7 @@ class Slack extends NotificationProvider {
"attachments": [
{
"color": (heartbeatJSON["status"] === UP) ? "#2eb886" : "#e01e5a",
"blocks": [
{
"type": "header",
"text": {
"type": "plain_text",
"text": textMsg,
},
},
{
"type": "section",
"fields": [{
"type": "mrkdwn",
"text": "*Message*\n" + msg,
},
{
"type": "mrkdwn",
"text": `*Time (${heartbeatJSON["timezone"]})*\n${heartbeatJSON["localDateTime"]}`,
}],
}
],
"blocks": blocks,
DaanMeijer marked this conversation as resolved.
Show resolved Hide resolved
}
]
};
Expand All @@ -86,26 +135,6 @@ class Slack extends NotificationProvider {
await Slack.deprecateURL(notification.slackbutton);
}

const baseURL = await setting("primaryBaseURL");

// Button
if (baseURL) {
data.attachments.forEach(element => {
element.blocks.push({
"type": "actions",
"elements": [{
"type": "button",
"text": {
"type": "plain_text",
"text": "Visit Uptime Kuma",
},
"value": "Uptime-Kuma",
"url": baseURL + getMonitorRelativeURL(monitorJSON.id),
}],
});
});
}

await axios.post(notification.slackwebhookURL, data);
return okMsg;
} catch (error) {
Expand Down