-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MS-Teams notification to use AdaptiveCards #4538
Refactor MS-Teams notification to use AdaptiveCards #4538
Conversation
Hi @CommanderStorm, did you have time to review my latest changes? Did those resolve all open ideas/issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think there is a bug in the screenshot from Refactor MS-Teams notification to use AdaptiveCards #4538 (comment) ^^
- Given that a lot has changed, could you update the screenshots in the descriptions?
This would make me way more confident in the review (it is easy to miss small things) ^^
That moment, when you're flooding your Teams with test notifications and achieve to screenshot the exact wrong one 🤦♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the bugfix/enhancement!
All changes in this PR are small (all cases [even those which are "nice to have"] are covered, only affects a previously broken provider) and uncontroversial ⇒ merging with junior maintainer approval
Hi @louislam, would this PR be worth putting into an upcoming 1.23.x release? |
We are only backporting bugfixes to 1.23.x, as only those can be shipped in patch releases. See the (now more hidden) changelog of
|
I have been playing around with Power Automate to post a message in Teams since #4922, as I have other custom applications that uses Teams webhooks as well. Apparently, I cannot just send a POST request to the webhook generated by Workflows if the channel I configured on the flow is private. Was this code tested on a private channel as well? |
Hi @lucas-alcantara, unfortunately sending messages to private channels using the PowerAutomate workflow is not supported by Microsoft (maybe because the bot doesn't have access to the private channel). See https://learn.microsoft.com/en-us/power-automate/teams/send-a-message-in-teams#known-issues-and-limitations |
Thanks! I could not find that page among the zillions of redundant/deprecated documentation pages Microsoft has. Is it worth mentioning that limitation on uptime kuma's docs as well? |
I don't know how popular this PowerAutomate thing is. Since we have a teams and not a power automate provider and this is a PA issue, I don't think this is nessesary to document We try to bake everything nessesary to set up a notification provider into the UI. https://github.com/louislam/uptime-kuma/blob/master/src/components/notifications/Teams.vue |
Hi, |
Using Workflows instead of webhooks also means changing the bits of documentation surrounding that. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #4457
Fixes #4464 (likely)
This PR changes the payload of the MS-Teams notification to use AdaptiveCards. The template is based on https://adaptivecards.io/designer. This solves the two issues mentioned in #4457:
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
The new layout in the PR looks like this:
UP
DOWN