Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): v2 Migration notice on ubuntu-latest label from ubuntu-latest to ubuntu-24.04 #5416

Closed
wants to merge 4 commits into from

Conversation

Zaid-maker
Copy link
Contributor

@Zaid-maker Zaid-maker commented Dec 6, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

BREAKING CHANGE

Updating migration ubuntu-latest to ubuntu-24.04 as per written in GitHub NOTICE. These are affecting all runners from 5 Dec, 2024 to 17 Jan, 2025.

Read the Blog here

Type of change

Please delete any options that are not relevant.

  • Breaking change (a fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@Zaid-maker Zaid-maker changed the title fix(ci): Deprection notice on ubuntu runner from ubuntu-latest to ubuntu-24.04 fix(ci): v2 Deprecation notice on ubuntu runner from ubuntu-latest to ubuntu-24.04 Dec 6, 2024
@louislam
Copy link
Owner

louislam commented Dec 7, 2024

I just read the blog. I think ubuntu-latest is not deprecated.

From my understanding, currently, ubuntu-latest is pointing to Ubuntu 22, and they will point to Ubuntu 24 soon.

Auto Test / auto-test (ubuntu-24.04, 18) (pull_request) Successful in 3m

According to your test, our auto-test is working fine on Ubuntu 24, so keep using ubuntu-latest should also be fine too.

@louislam louislam added the question Further information is requested label Dec 7, 2024
@Zaid-maker
Copy link
Contributor Author

Zaid-maker commented Dec 7, 2024

My mis-understanding it's migration not deprecation

From my understanding, currently, ubuntu-latest is pointing to Ubuntu 22, and they will point to Ubuntu 24 soon.

No no, they are migrating the label of ubuntu-latest to just ubuntu-24.04 and ubuntu-22.04.

According to your test, our auto-test is working fine on Ubuntu 24, so keep using ubuntu-latest should also be fine too.

You are right we can still keep but why not stay updated on updates. but still we can draft this.

@Zaid-maker Zaid-maker changed the title fix(ci): v2 Deprecation notice on ubuntu runner from ubuntu-latest to ubuntu-24.04 fix(ci): v2 Migration notice on ubuntu-latest label from ubuntu-latest to ubuntu-24.04 Dec 7, 2024
@Zaid-maker
Copy link
Contributor Author

Zaid-maker commented Dec 7, 2024

I think the status has some bugs on showing status of actions

image

But the jobs are looks fine...

image

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Dec 7, 2024

I think the status has some bugs on showing status of actions

Not a bug:
Louis has set the expected actions up as needed/expected for a merge.
Since the name has changed, they are no longer being run as far as github is concearned.

@louislam
Copy link
Owner

louislam commented Dec 7, 2024

No no, they are migrating the label of ubuntu-latest to just ubuntu-24.04 and ubuntu-22.04.

I just re-read the blog again, I still think my understanding is correct.

We will migrate the ubuntu-latest label to ubuntu 24 starting on December 5, 2024

The sentence might be a bit confusing alone, but the word "migrate" here means that, migrate 22 to 24 for the ubuntu-latest tag, according to following paragraphs and content.

Also found more source: actions/runner-images#10636

Ubuntu-latest workflows will use Ubuntu-24.04 image

Ubuntu 24.04 is ready to be the default version for the "ubuntu-latest" label in GitHub Actions and Azure DevOps.

So ubuntu-latest will still be available afterwards, pinning to 24.04 is not necessary.

@Zaid-maker Zaid-maker closed this Dec 8, 2024
@Zaid-maker Zaid-maker deleted the fix-action-runner-v2 branch December 8, 2024 07:48
@Zaid-maker
Copy link
Contributor Author

This PR closed for now, and can be opened again in future. Thanks for clarification ♥️

@Zaid-maker Zaid-maker restored the fix-action-runner-v2 branch January 10, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants