Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nostr notification provider #5495

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zappityzap
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

  • Update nostr-tools to 2.10.4
  • Support relays that require AUTH like auth.nostr1.com
  • Tested with Node 18, 20 and 22

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Event After
UP up-after
DOWN down-after
Certificate-expiry certificate-after
Testing test-after

@CommanderStorm CommanderStorm changed the title Update nostr notification provider chore: update nostr notification provider Jan 24, 2025
@CommanderStorm
Copy link
Collaborator

About this PR:
What is the motivation?
Is this breaking for existing users?

@CommanderStorm CommanderStorm added question Further information is requested area:notifications Everything related to notifications type:enhance-existing feature wants to enhance existing monitor labels Jan 24, 2025
@zappityzap
Copy link
Contributor Author

Main motivation is to get the library updated since the protocol is evolving quickly. There's a newer method for sending direct messages with better privacy that I'd like to implement, but it's not widely supported yet, and it requires a newer library.

Additionally, some public relays require a sender to respond to an AUTH challenge before accepting a direct message event to reduce potential spam. This PR enables responding to those AUTH challenges, making it easier to use this notification provider.

@CommanderStorm
Copy link
Collaborator

Is this breaking for existing users?

@zappityzap
Copy link
Contributor Author

Sorry, I didn't understand the question at first. This doesn't break anything for existing users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications question Further information is requested type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants