-
-
Notifications
You must be signed in to change notification settings - Fork 6k
fix: make sure that stripping backslashes for notification urls cannot cause catastophic backtracking (ReDOS) #5573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… attacks and update error messages in test cases.
modified the regular term matching rule Co-authored-by: Frank Elsinga <frank@elsinga.de>
remove the test file
More concise and reasonable regular expression fix Co-authored-by: Frank Elsinga <frank@elsinga.de>
More concise and reasonable regular expression fix
/home/runner/work/uptime-kuma/uptime-kuma/server/notification-providers/pushdeer.js /home/runner/work/uptime-kuma/uptime-kuma/server/notification-providers/whapi.js |
Could you fix the linting issues? |
I have fixed the issue with the regularization term, please check it out |
Hello, sorry to bother you. I would like to ask if I want to apply for a CVE for this vulnerability, what should I do? Can I submit the vulnerability through the Security module in your warehouse? I submitted a document about this vulnerability not long ago. Application, but there has been no reply yet. I look forward to hearing from you. Thank you very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only @louislam can manage the security reports.
I have no access there.
But for this one (i.e. not https://github.com/louislam/uptime-kuma/security/advisories/GHSA-5rg9-2hjc-q924, as that turned out to not be a vulnerability), I think we can publish one.
I will release a security vulnerability related to these two regularization terms. Could you please help me contact the author and ask them to pay attention as soon as possible? Thank you very much for your help |
this is the security url:GHSA-hx7h-9vf7-5xhg |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #5574
By modifying the regular expression matching rule to /(?<!/)/*$/, we prevent the matching process from starting with a slash. This change ensures that the matching can only start from the first slash and proceed toward the end. For each subsequent slash, the regular expression checks if the previous character is a slash; if so, it will not backtrack further.
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)