Feature/metadata #2
Draft
+415
−377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good so far. Still need to add the rest of the meta data support including validation of data |
In testing this does not appear to be working. In the watch window the addresses of the metadata are nearly 2MB away from the addresses of the working variables
rynojones7
reviewed
Sep 13, 2023
persistInternalRestore.c
Outdated
Comment on lines
69
to
73
| if(Persistence->Internal.WorkingVariableInfo[i].pMetadata->variableSize == Persistence->Internal.WorkingVariableInfo[i].sizeofWorkingVariable | ||
| &&Persistence->Internal.WorkingVariableInfo[i+1].pMetadata != 0){ | ||
| *(BOOL*)Persistence->IN.pDataValid = 0; | ||
| return (UINT)PERSIST_ERR_DATAMOVED_CHANGED; | ||
| } |
There was a problem hiding this comment.
This is a breaking change, it should be removed for this PR and revisited later.
rynojones7
reviewed
Sep 13, 2023
Comment on lines
+60
to
+63
| DTGetTime_typ getTime; | ||
|
|
||
| getTime.enable = 0; | ||
| DTGetTime(&getTime); |
There was a problem hiding this comment.
This doesn't look like it is being used. Should be either removed or be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds memory allocation for a metadata struct corresponding to each variable we are saving in permanent memory.
Why:
This is being done in conjunction with an updated configuration system. The hope is to eventually store metadata which can allow us to determine if the data is invalid without needing to have a separate persistent dataValid array.
Next steps:
The intention of this system is to provide the persistent memory with a way to verify its validity. The metadata struct has a
pSelfmember, which is intended to be its address in memory. By checking that this is true for all members in the persistent memory, and that the following metadata object is the expected distance (sizeof(metadata) + metadata.sizeofVar) we can verify that the data in permmemory has been properly initialized. Once this step has been taken, we can verify that the current sizes of the variables match what we expect them to with the permanent memory, and if needed write a function to re-define those pointers to restore as much valid data as possible from the persistent memory.