Feature/rc1 #16
Open
Feature/rc1 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanereetz
reviewed
May 29, 2024
| CASE seq.doStep() OF | ||
| 0: | ||
| IF seq.onEntry() THEN | ||
| // axis1.power( seq ); |
There was a problem hiding this comment.
There are double-comments here
shanereetz
reviewed
May 29, 2024
Comment on lines
+41
to
+42
| //MultiCaller1(); | ||
| //MultiCaller1.Execute := FALSE; |
There was a problem hiding this comment.
Suggested change
| //MultiCaller1(); | |
| //MultiCaller1.Execute := FALSE; |
Remove commented lines
shanereetz
reviewed
May 29, 2024
| FinishAfterTimeout(SingleCommand1); | ||
| FinishAfterTimeout(singleCommand2); | ||
| command(MultiCommand); | ||
| (* |
There was a problem hiding this comment.
Is this whole commented section intended to be here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This is the first release candidate. Looking for feedback on AP, functionality, naming and implementation where relevant. Internals are less relevant at this point and may still change in future versions.
Why:
We want to get this to a releasable version to start making docs and examples.