Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Annotated support #257

Merged
merged 12 commits into from
Jun 23, 2024
Merged

Conversation

mvanderlee
Copy link
Contributor

Fixes #256

Moving away from NewType and instead add Annotated support.

@mivade
Copy link

mivade commented Mar 9, 2024

I would recommend importing Annotated from typing_extensions for Python 3.8 support (at least for as long as that continues receiving security updates).

@mvanderlee mvanderlee changed the title Add Annotated support and therefore set minimum python version as 3.9 Add Annotated support Mar 10, 2024
@lovasoa lovasoa requested a review from dairiki March 11, 2024 07:01
@dairiki dairiki mentioned this pull request Mar 11, 2024
@mvanderlee
Copy link
Contributor Author

Rebased, and retested.

@mvanderlee
Copy link
Contributor Author

@lovasoa @dairiki Any idea when you'll have time to review this? I'd like to see this merged so I can rebase and finalize the generic dataclass PR #259

Copy link
Collaborator

@dairiki dairiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay. (Life has been crazy.)

The feature addition is a good one, I think. (Thank you!) And other than some style nits, I think it looks fine.

I think the addition of tox test configuration is long overdue. Ideally, it would be a separate PR, but since it's in here, already, I'm fine leaving it here. I do have a few comments about that.

marshmallow_dataclass/__init__.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
marshmallow_dataclass/__init__.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@mvanderlee
Copy link
Contributor Author

mvanderlee commented Jun 18, 2024

I apologize for the delay. (Life has been crazy.)

The feature addition is a good one, I think. (Thank you!) And other than some style nits, I think it looks fine.

I think the addition of tox test configuration is long overdue. Ideally, it would be a separate PR, but since it's in here, already, I'm fine leaving it here. I do have a few comments about that.

I haven't had time since either, so I get it. Thank you for taking the time to review it!

@mvanderlee
Copy link
Contributor Author

I think I've resolved all issues. The PR is ready for review again.

Copy link
Collaborator

@dairiki dairiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my local dev environment, I'm having a few issues with the tox.ini.

Otherwise, LGTM.

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@mvanderlee
Copy link
Contributor Author

I've removed tox.ini from this PR.

Somehow, the line-endings in README got switched to DOS (CRLF) rather
than UNIX (LF). That resulted in an unreadable diff.
@dairiki dairiki merged commit f6b8a8e into lovasoa:master Jun 23, 2024
6 checks passed
@dairiki
Copy link
Collaborator

dairiki commented Jun 23, 2024

Merged. Thank you, @mvanderlee !

I tried to make a new PyPI release (8.7.0) but #270 happened.

@dairiki
Copy link
Collaborator

dairiki commented Jun 23, 2024

Now released in 8.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor 'NewType' as it no longer conforms to the typing spec
3 participants