Open
Conversation
Member
Author
|
Links are broken by github autolinking, the second one is accessible via wallento#5 |
This adds a beta Github action that is run on pushes and pull requests. It automatically annotates the sources with linter issues. Nothing extra is needed beyond merging. Signed-off-by: Stefan Wallentowitz <stefan.wallentowitz@hm.edu>
imphil
reviewed
Sep 1, 2021
Contributor
imphil
left a comment
imphil
left a comment
There was a problem hiding this comment.
Uh, turns out I completely forgot about this; sorry @wallento!
To clarify, this is using Verilator as linter and posts comments as code annotations, while #1427 uses Verible lint and posts lint output as comments (which we can then reply to).
Effectively the two PRs do two different things in two different ways. Since it is not really clear a the moment which approach to present linter output to the user is better, I'm happy to give both approaches a try and we can then improve as we move along.
imphil
reviewed
Sep 1, 2021
| @@ -0,0 +1,25 @@ | |||
| on: [push, pull_request] | |||
Contributor
There was a problem hiding this comment.
Can you add a license header here?
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| name: Linter |
Contributor
There was a problem hiding this comment.
Suggested change
| name: Linter | |
| name: RTL lint with Verilator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a beta Github action that is run on pushes and pull
requests. It automatically annotates the sources with linter issues.
Nothing extra is needed beyond merging.
As a demo you can see how new PRs will fail: wallento#4
They will then show the annotation: wallento@bbf8e10
Removing the current waiver looks like this as a test: wallento@966649b
So, you can see that it will also annotate files outside the changeset.
There will be robustness extensions, but I think it is usable and I would love ibex as beta testers. It can be deactivated or removed as easily as it was added :)