Add support for parsing to dynamic #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @lpil! Can I bump you about this PR? |
lpil
reviewed
Jan 10, 2026
Owner
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Hello! Thank you for this! Will be super useful.
I've left some notes inline. One of the main things is that new_primitive_decoder is being used a lot instead of the regular decode API. new_primitive_decoder is for decoding primitives via FFI, it's not needed to compose decoders, they already compose!
src/tom.gleam
Outdated
| } | ||
| } | ||
|
|
||
| /// Convert a parsed TOML document into a `Dynamic`. |
Owner
There was a problem hiding this comment.
Fill in this documentation with what it is for please 🙏
Author
There was a problem hiding this comment.
I filled this out for both to_dynamic and parse_to_dynamic. Let me know what you think :)
src/tom.gleam
Outdated
| } | ||
|
|
||
| /// A convenience for parsing a TOML document and immediately converting it to a Dynamic | ||
| pub fn parse_dynamic(input: String) -> Result(Dynamic, ParseError) { |
Owner
There was a problem hiding this comment.
Same here, more documentation please.
Also let's call it parse_to_dynamic, to make it a bit clearer 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
This PR adds the ability to either parse directly to a
dynamic(parse_dynamic) or convert an existing TOML document to a dynamic (to_dynamic). I had to do some dynamic building like we discussed on Discord, so hopefully this matches with what we discussed 😅. I've also added decoders for all custom types, so that callers do not have to use the known forms themselves if they don't want to.I've also added a JS test target to the CI, since there's FFI involved now.
Let me know if you'd like anything fixed up!