Skip to content

Update conventionalcommit.json #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update conventionalcommit.json #91

wants to merge 1 commit into from

Conversation

@bluelovers
Copy link

@bluelovers bluelovers commented Jun 27, 2022

@lppedd
Copy link
Owner

lppedd commented Jun 28, 2022

The big problem is the footer parser does not work correctly with two separate words as of now.
I think for this to work correctly we'd need to wait that I re-structure the completion provider to use the new PSI layer.

@lppedd lppedd self-assigned this Jun 28, 2022
@lppedd
Copy link
Owner

lppedd commented Jun 29, 2022

Also, to be complete: the docs states

BREAKING-CHANGE MUST be synonymous with BREAKING CHANGE, when used as a token in a footer.

So you can safely use the currently available one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lppedd lppedd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bluelovers @lppedd