Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move repository from yarn to npm #309

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Conversation

matthiaslehnertum
Copy link
Collaborator

@matthiaslehnertum matthiaslehnertum commented Oct 9, 2023

As per Stephan's request, this PR updates all of Apollon's dependencies to a recent version, replaces yarn by npm as a package manager and replaces tslint with eslint.

At the moment, a lot of the eslint default rules are disabled to have eslint behave the same way as tslint behaved before. In the future, we should sequentially reenable these rules and fix the issues detected. To not make this PR unnecessarily large, I decided to not do this in the current PR.

Motivation and Context

A lot of Apollon's dependencies, especially tslint, were outdated.

Steps for Testing

The most sensible test for this change would be to test if running and building the application behaves as expected.

@matthiaslehnertum matthiaslehnertum marked this pull request as ready for review October 10, 2023 15:54
Copy link
Contributor

@AlexanderG2207 AlexanderG2207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested with npm locally. All tests pass and everything seems to be working as usual in the editor. I would just adjust the README to accommodate the npm implementation.

README.md Show resolved Hide resolved
Copy link
Contributor

@AlexanderG2207 AlexanderG2207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting the Readme. Looks good to me👍

@matthiaslehnertum matthiaslehnertum merged commit e985fa6 into develop Oct 12, 2023
3 checks passed
@matthiaslehnertum matthiaslehnertum deleted the feature/move-to-npm branch October 12, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants