-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/Enhancement
Fixed version control related bugs
#107
Conversation
- dto changes from url to uri - vcs update from bitbucket away to local vc/ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as Student, Tutor, and Instructor and worked well. No of the issues occurred. The settings page looks good as well. Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may only be a partial fix for #104. The error message is still
Id of the opened submission and the loaded Artemis page do not match, loading of feedback aborted. Make sure to open the correct submission in Orion.
I tried replicating this issue and couldn't get it replicated. Does setting up the entire correction repository fix the issue? |
What does setting up the entire correction repository mean? Do I have to do something else as an instructor in the IDE before I can start the assessment of student submissions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- New settings field is present
- Student: Open in IDE; submit works
- Tutor: Assess in IDE via assessment dashboard works
- Instructor: Edit exercise in IDE works
- Instructor: Assess via scores page works
I was unable to reproduce the bug in #104.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally works well, also code lgtm
Motivation and Context
Artemis has changed DTOs from URL to URI which broke some plugin code that depends on the repository URLs.
ls1intum/Artemis#7838
Furthermore Artemis has changed the version-control system away from Bitbucket. Orion however still referenced the TUM bitbucket
This pr fixes:
#104
#105
#106
Description
Steps for Testing
2.1. As a student
2.2. As a tutor
2.3. As an instructor
-> verify that the cloning process does not throw errors as described in the linked issues
Review Progress
Code Review
Manual Tests
Screenshots
Updated Settings UI