-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication
: Fix link rendering for attachments and show uploaded images in chat
#109
Communication
: Fix link rendering for attachments and show uploaded images in chat
#109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the functionality, slides and lecture units are displayed correctly, and clicking them navigates to the repsective part of the app. When clicking on slides I get redirected to the browser but I actually do not have to authenticate there. Maybe this is because I was already logged into the server in chrome?
Showing images in the chat works.
...um/informatics/www1/artemis/native_app/feature/metis/conversation/ui/thread/MetisThreadUi.kt
Outdated
Show resolved
Hide resolved
...um/informatics/www1/artemis/native_app/feature/metis/conversation/ui/thread/MetisThreadUi.kt
Outdated
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/core/common/markdown/PostArtemisMarkdownTransformer.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/markdown/LocalMarkwon.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/markdown/MarkdownText.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/markdown/MarkdownText.kt
Outdated
Show resolved
Hide resolved
...um/informatics/www1/artemis/native_app/feature/metis/conversation/ui/thread/MetisThreadUi.kt
Outdated
Show resolved
Hide resolved
...um/informatics/www1/artemis/native_app/feature/metis/conversation/ui/thread/MetisThreadUi.kt
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationViewModel.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When checking out the branch the reload jittering with images still persist, but tbh I think we should create a separate issue / PR for this at this point and get this PR merged, I think people are waiting for the fixes and features of this PR
I agree. I noticed that if the images are smaller than the default height, there is jittering. For images that have a greater original height, it doesn't happen. |
Description
This PR fixes an issue that caused lecture attachments such as slides and lecture units to not correctly render as links. Furthermore, it changes the ProvideMarkwon composable to use a custom ImageLoader that is generated by a new class called DefaultImageProvider and is capable of handling authorization. DefaultImageProvider has been introduced to request server images and is also used for the course images now. All images that have been uploaded to the server can be displayed now.
This PR will close #61
Important side note:
Although the links to lecture attachments are displayed correctly now, users still face an authorization error and do not get access to the resource. Fixing this issue is outside the scope of this PR.
Screenshots