Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Prepare websocket for compressed payload #197

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

FelberMartin
Copy link
Collaborator

@FelberMartin FelberMartin commented Dec 6, 2024

Problem Description

To reduce the load on the server with sent websocket updates, the Artemis team decided to compress the payloads of websocket updates if the exceed a certain threshold.

This PR closes #195

Changes

  • Added check for the websocket compression header and optionally decompress the websocket payload
  • Added tests for both compressed and normal payloads

Steps for testing

As the compression is not yet live on any servers, we can only test that un-compressed payloads work as before.

  • Go to any chat with the app
  • Write a message to that chat from the webapp
  • Observe that the new message is immediately displayed on the app (without the need for a refresh)

@FelberMartin FelberMartin changed the title Chore/websocket compressed payload Chore: Prepare websocket for compressed payload Dec 6, 2024
@FelberMartin FelberMartin linked an issue Dec 7, 2024 that may be closed by this pull request
@FelberMartin FelberMartin self-assigned this Dec 7, 2024
@FelberMartin FelberMartin marked this pull request as ready for review January 16, 2025 09:11
Copy link
Contributor

@eylulnc eylulnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a some related to message deleting but could not reproduced it after the second build.
When I tried to delete a message I got the pop up for - Could not delete the message.

@FelberMartin
Copy link
Collaborator Author

I had a some related to message deleting but could not reproduced it after the second build. When I tried to delete a message I got the pop up for - Could not delete the message.

Okay that's weird, these websocket changes should actually have no effect on the deletion of messages🤔. In case you find a way to reproduce the bug, please also try whether it occurs on develop aswell.

I also tried reproducing the error but did not get an error pop up.

@FelberMartin FelberMartin requested a review from eylulnc January 17, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Prepare websockets for compressed payloads
2 participants