-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix
: Only show resolve post if actionable
#252
Bugfix
: Only show resolve post if actionable
#252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Also implementation too, I have check it for both student and instructor.
Resolve not visible for students ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested it and the resolve post action does not show up.
Code lgtm, nice cleanup of the test file!
Problem Description
The "Resolves Post" action did wrongly show up for when selecting a users own answer post, even when the user has no tutor rights and he is not the thread base post author.
This closes #240.
Changes
IAnswerPost
to include the parentAuthorIdIStandalonePost
instead ofPostPojo
for easier testingSteps for testing
Prerequisites: user without tutor rights