-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature
: Send message via user dialog
#285
Feature
: Send message via user dialog
#285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When clicking on the user profile picture in the chat it works as expected.
The navigation works great, good work!
When clicking on the user profile picture in the ConversationMemberList
the app crashes with the following stacktrace:
One more comment on the dialog:
I think it would be nice to stick to the new role badges from now on and use this design (see iOS app):
Good catch, this is fixed now :D
I created a follow-up issue for this as this change should then also affect the ConversationMembersList and bloat the scope of this PR: #289 |
…er-dialog # Conflicts: # feature/metis/conversation/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/BaseChatUITest.kt # feature/metis/conversation/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationProfilePictureUiTest.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Crash is fixed when clicking the image.
From yourself -> see that "Send message" button is not shown ✅
From someone else, click on "Send message" -> navigated to DM chat ✅
Navigate back -> previous chat is shown ✅
Click on a user mention in a post -> navigated to DM chat ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good now, no more crash!
Code also lgtm.
Problem Description
As described in #213 the "Send message" button in the user profile dialog has been postponed.
This PR closes #213
Changes
LocalVisibleMetisContextManager
to being able to extract current metisContext, to avoid passing down the courseId all the time.Steps for testing