Feature: Unread posts indicator
#375
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
FelberMartin
force-pushed
the
feature/communication/unread-posts-indicator
branch
from
980a509 to
e990bcf
Compare
FelberMartin
changed the base branch from
develop
to
bugfix/communication/not-increase-unread-counter-in-chat
FelberMartin
force-pushed
the
feature/communication/unread-posts-indicator
branch
from
e990bcf to
84aafb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
When navigating to a chat with unread posts, the users had no clear indicator where the new unread posts begin. This PR adds an unread indicator inspired by slack and ls1intum/Artemis#10018
Changes
Steps for testing
Screenshots
Follow-up
Known bug:
When the unread counter in the ConversationOverview increases due to a websocket update (the user is currently in the communication tab and a new post in a chat that is not open is sent), then the unread indicator is not displayed. This is due to the unread counter only being updated in the ConversationOverviewViewmodel. This bug will be tackled with #394