Bugfix: Fix PostItem scaling
#382
Merged
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eylulnc
changed the title
Bugfix: Fix PostItem scaling issueBugfix: Fix PostItem scaling
ahbitaqu
reviewed
Feb 4, 2025
|
Emoji's should not be cutted out now. The icon button on the other hand is not someth 
|
FelberMartin
approved these changes
Feb 5, 2025
julian-wls
approved these changes
Feb 7, 2025
FelberMartin
added
ready to merge
|
@eylulnc There is one merge conflict, once that one is fixed, feel free to add the "Ready to merge" label :) |
…into bugfix/communication/fix-post-scaling # Conflicts: # feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
When the user adjusts the system font size (for accessibility or personal preference), certain text elements—especially those rendered via our custom MarkdownText composable—do not scale properly. This leads to inconsistent UI: standard Compose Text elements scale up/down, but the markdown text remains the same size.
Changes
Fixed Markdown Text Scaling
Replaced TypedValue.COMPLEX_UNIT_DIP with TypedValue.COMPLEX_UNIT_SP in our MarkdownText composable.
Ensured that any text size set on the underlying TextView is in scale‐independent pixels (sp), so it respects the user’s font‐size setting.
Removed Fixed DP Constraints
Updated components (like HeadlineProfilePicture) that had hard‐coded dp sizes, allowing them to scale if desired or remain flexible in layout.
Steps for testing
Go to the device’s Settings → Display → Font size and select “Largest.” ( Also among other font settings)
Return to App and open a communication channel
Check in the channel Post Header is no longer clipped and the post content size is also updated according to the font size you arranged.
Check that the profile picture also resizes to align with the new header height.
Screenshots
Regular and Largest font size