-
Notifications
You must be signed in to change notification settings - Fork 1
Feature
: Add course wide channels
#416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature
: Add course wide channels
#416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change, works as expected. All users were added to the channel.
Just one general remark, see below
..._app/feature/metis/manageconversations/ui/conversation/create_channel/CreateChannelScreen.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After addressing the code comment, feel free to switch to the "ready to merge" label :)
Problem Description
A new Course Scope option has been introduced in the Create Channel dialog, allowing users to choose between course-wide and selective channels, with selective set as the default. This functionality aligns with the existing implementation on the Web version to ensure consistency across platforms.
Changes
Toggle Added to the Create Channel View
Added isCourseWide: Boolean to the ChannelChat model.
Modified ConversationService to include isCourseWide as part of the channel creation request.
Steps for testing
Log in to Artemis.
Navigate to the Communication section of a course.
Click the plus (+) gab button and select Create Channel.
Observe the new Channel Scope option and select Course-wide to create a channel.
Verify that all course members are automatically added to the newly created channel.
Screenshots