Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small UI Improvements #54

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Small UI Improvements #54

merged 6 commits into from
Oct 25, 2024

Conversation

FelberMartin
Copy link
Collaborator

  • Beta Version Dialog: Press on text now also toggle checkbox
  • Made CodeOfConduct button less prominent and more similar to iOS
    image
  • CreateChat: Enhanced search texts by adding a text when the search query is too short
    image

julian-wls
julian-wls approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm!

asliayk
asliayk approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@asliayk asliayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it and it works as expected

TimOrtel
TimOrtel requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@TimOrtel TimOrtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good. I just saw a few minor things.

...is/manageconversations/ui/conversation/create_personal_conversation/PotentialRecipientsUi.kt Outdated Show resolved Hide resolved
...is/manageconversations/ui/conversation/create_personal_conversation/PotentialRecipientsUi.kt Outdated Show resolved Hide resolved
...ve_app/feature/metis/manageconversations/ui/conversation/member_selection/MemberSelection.kt Outdated Show resolved Hide resolved
...e/metis/manageconversations/ui/conversation/member_selection/MemberSelectionBaseViewModel.kt Outdated Show resolved Hide resolved
...e/metis/manageconversations/ui/conversation/member_selection/MemberSelectionBaseViewModel.kt Outdated Show resolved Hide resolved
@FelberMartin FelberMartin self-assigned this Oct 18, 2024
@FelberMartin FelberMartin requested a review from TimOrtel October 18, 2024 21:10
@FelberMartin
Copy link
Collaborator Author

@TimOrtel Could you quickly review my changes? :D

TimOrtel
TimOrtel approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@TimOrtel TimOrtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one comment but apart from that it looks good

...is/manageconversations/ui/conversation/create_personal_conversation/PotentialRecipientsUi.kt Show resolved Hide resolved
@FelberMartin FelberMartin merged commit 40c2f09 into main Oct 25, 2024
3 of 4 checks passed
@FelberMartin FelberMartin deleted the general/small_ui_improvements branch October 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimOrtel TimOrtel TimOrtel approved these changes

@asliayk asliayk asliayk approved these changes

@julian-wls julian-wls julian-wls approved these changes

Assignees

@FelberMartin FelberMartin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FelberMartin @julian-wls @asliayk @TimOrtel