Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing strings to notification settings #56

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

julian-wls
Copy link
Contributor

@julian-wls julian-wls commented Oct 18, 2024

Description

This PR adds missings strings for the Notification settings to resolve #55 .

Screenshots

Screenshot2

Screenshot

@julian-wls julian-wls self-assigned this Oct 18, 2024
@julian-wls julian-wls requested a review from TimOrtel October 18, 2024 13:30
Copy link
Contributor

@TimOrtel TimOrtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but the changes look reasonable.

Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@FelberMartin FelberMartin merged commit c29dea3 into main Oct 23, 2024
2 of 3 checks passed
@FelberMartin FelberMartin deleted the bugfix/notification-strings branch October 23, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Translatios for notification types
3 participants