-
Notifications
You must be signed in to change notification settings - Fork 1
Communication
: Resolve Post functionality for threads
#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… the textfield when editing posts
…iewModel to automatically apply changes to the view
...rtemis/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImpl.kt
Outdated
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
...de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostActions.kt
Outdated
Show resolved
Hide resolved
...rmatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostContextBottomSheet.kt
Outdated
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Outdated
Show resolved
Hide resolved
… for testing (will be fixed with #58)
Looks great so far! Just two minor issues:
Thanks for working on this :) |
Also, is there any way we could make the resolved tags colored in green? might improve the visual overview drastically |
That's correct, but as described in the discussion above this problem is unrelated to this pr and is part of issue #60
Sure, that’s something I had in mind, too. However I think this should happen in form of another pr that improves the overall design of post items to align them with iOS. I don’t think it fits the current state of the design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info! Good to go from my side
Just that we're on the same page: the resolve button doesn't work at all. It's not just the UI, the information is never reflected on the server even through the web view. As I understand #60 deals with local representation only |
Thanks for pointing that out. Just checked it, and I somehow forgot to invoke the function call in my previous commit. Sorry for the confusion. Should work now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now, Thank you! :)
...m/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Outdated
Show resolved
Hide resolved
...um/informatics/www1/artemis/native_app/feature/metis/conversation/ui/thread/MetisThreadUi.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check your junit tests. They seem to be failing in the ci
...tics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesE2eTest.kt
Outdated
Show resolved
Hide resolved
...atics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesUITest.kt
Outdated
Show resolved
Hide resolved
...atics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesUITest.kt
Outdated
Show resolved
Hide resolved
...atics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesUITest.kt
Outdated
Show resolved
Hide resolved
...atics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesUITest.kt
Outdated
Show resolved
Hide resolved
...atics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesUITest.kt
Outdated
Show resolved
Hide resolved
...atics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesUITest.kt
Outdated
Show resolved
Hide resolved
...atics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesUITest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, looking forward to merge this as soon as possible. Just one small fix :)
Description:
This PR includes the following features and fixes:
Screenshots:
Fig. 1:

Fig. 2:

If the post already resolves the parent posts users can remove this tag:
