Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Fix Tagging other Users does not work #71

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

FelberMartin
Copy link
Collaborator

@FelberMartin FelberMartin commented Oct 24, 2024

This resolves issue #65

Now using a different API endpoint for searching tag candidates (matching iOS and WebApp behaviour).

Out of Scope
While testing the implementation I found minor bugs / chances to improve the UI/UX, but I will create a separate issue #72 for this. This PR only focusses on the functionality.

@FelberMartin FelberMartin self-assigned this Oct 24, 2024
@FelberMartin FelberMartin linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it and it works as expected. Good work!

The only thing I noticed is, that the preview doesn't get rendered after clicking on the preview button. However, this seems like a topic for another PR in my opinion as it is not really related to the topic of this PR and more related to markdown rendering.

Good to be merged from my side!

Copy link
Contributor

@TimOrtel TimOrtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a UI test for this tagging behaviour. Also add an integration test that checks that the application can talk to the server properly.

@FelberMartin
Copy link
Collaborator Author

FelberMartin commented Oct 24, 2024

Also add an integration test that checks that the application can talk to the server properly.

@TimOrtel Could you elaborate, please? I am not sure what you mean by "the application can talk to the server properly". Should this just be a generic test whether the ConversationViewModel can communicate with a MockServer via requestReload() or should the test somehow be tailored to the tagging behaviour? If so, how?

Copy link
Contributor

@TimOrtel TimOrtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add tests that verify:

  • Initially the auto complete hints are not displayed
  • when entering text that is not @ then the auto complete hints are not displayed
  • when entering an @ the hints are displayed but when removing the @ again the hints are no longer displayed
  • auto completing can be used twice in a row

@TimOrtel
Copy link
Contributor

Also add an integration test that checks that the application can talk to the server properly.

@TimOrtel Could you elaborate, please? I am not sure what you mean by "the application can talk to the server properly". Should this just be a generic test whether the ConversationViewModel can communicate with a MockServer via requestReload() or should the test somehow be tailored to the tagging behaviour? If so, how?

You can see exemplary integration tests in feature/metis/conversation/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ConversationAnswerMessagesE2eTest.kt

@FelberMartin FelberMartin changed the base branch from main to develop October 25, 2024 13:50
@FelberMartin FelberMartin requested a review from TimOrtel October 25, 2024 13:50
@FelberMartin FelberMartin requested a review from TimOrtel October 25, 2024 17:05
@FelberMartin FelberMartin requested a review from TimOrtel October 31, 2024 09:43
Copy link
Contributor

@TimOrtel TimOrtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

@julian-wls julian-wls added the ready to merge This PR can be merged label Nov 13, 2024
@FelberMartin FelberMartin merged commit 2f2d1e9 into develop Nov 14, 2024
3 of 4 checks passed
@FelberMartin FelberMartin deleted the bugfix/taggingUsersAutocompletionNotShowing branch November 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communication: Tagging other user does not work
3 participants