Merge branch 'main' into feature/make-nginx-timeouts-configurable

.ansible-lint

@@ -1,3 +1,9 @@
+exclude_paths:
+- .cache/  
+- .github/
+
+
 skip_list:
   - '403'  # Package installs should not use latest
   - '208'  # File permissions unset or incorrect
+  - no-tabs

.github/workflows/code_quality.yml

@@ -12,46 +12,13 @@ jobs:
     # Important: This sets up your GITHUB_WORKSPACE environment variable
     - uses: actions/checkout@v2
 
-    - name: Lint Ansible Playbook
-      # -> https://github.com/ansible/ansible-lint-action/issues/45
-      # replace "master" with any valid ref
-      uses: ansible/ansible-lint-action@master
+    - uses: actions/setup-python@v2
       with:
-        # [required]
-        # Paths to ansible files (i.e., playbooks, tasks, handlers etc..)
-        # or valid Ansible directories according to the Ansible role
-        # directory structure.
-        # If you want to lint multiple ansible files, use the following syntax
-        # targets: |
-        #   playbook_1.yml
-        #   playbook_2.yml
-        targets: ""
-        # [optional]
-        # Arguments to override a package and its version to be set explicitly.
-        # Must follow the example syntax.
-        override-deps: |
-          ansible==2.11.6
-          ansible-lint==5.2.1
-        # [optional]
-        # Arguments to be passed to the ansible-lint
+        python-version: '3.9'
+        cache: 'pip'
 
-        # Options:
-        #   -q                    quieter, although not silent output
-        #   -p                    parseable output in the format of pep8
-        #   --parseable-severity  parseable output including severity of rule
-        #   -r RULESDIR           specify one or more rules directories using one or
-        #                         more -r arguments. Any -r flags override the default
-        #                         rules in ansiblelint/rules, unless -R is also used.
-        #   -R                    Use default rules in ansiblelint/rules in addition to
-        #                         any extra
-        #                         rules directories specified with -r. There is no need
-        #                         to specify this if no -r flags are used
-        #   -t TAGS               only check rules whose id/tags match these values
-        #   -x SKIP_LIST          only check rules whose id/tags do not match these
-        #                         values
-        #   --nocolor             disable colored output
-        #   --exclude=EXCLUDE_PATHS
-        #                         path to directories or files to skip. This option is
-        #                         repeatable.
-        #   -c C                  Specify configuration file to use. Defaults to ".ansible-lint"
-        args: ""
+    - name: Install python dependencies 
+      run: pip install -r requirements.txt
+
+    - name: Execute ansible-lint
+      run: ansible-lint

requirements.txt

@@ -1,6 +1,6 @@
 ansible==5.0.1
 ansible-core==2.12.1
-ansible-lint==4.3.7
+ansible-lint==5.3.2
 cffi==1.15.0
 colorama==0.4.4
 commonmark==0.9.1

roles/storage_client/tasks/main.yml

@@ -25,7 +25,7 @@
     name: mnt-storage.mount
     state: stopped
   become: true
-  ignore_errors: true
+  ignore_errors: true # noqa ignore-errors
 
 - name: Make sure the mountmoint exists
   file: