Fix deployment user permissions #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hialus
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the deployment user was in the
sudogroup and was therefore able to execute all commands.This somehow circumvented the usage of our
roles/artemis/templates/artemis_deployment_sudoers.j2template.With this change, we remove the deployment user from the
sudoandartemisgroup so that the deployment user has only minimal access rights.Additionally, the deployment user was able to execute arbitrary commands in the docker container using the deployment script and
execprovided by docker compose. Especially as we want the deployment user not to be able to read the configuration and secrets, we now limit the set of commands of theartemis-docker.shscript torestart.