Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to redirect to main URL #53

Closed
wants to merge 7 commits into from

Conversation

bensofficial
Copy link
Member

This change adds the option to add a main URL. If the main URL is defined, then all requests will be redirected to the main URL.

@bensofficial bensofficial added enhancement New feature or request role.proxy labels Nov 27, 2023
@bensofficial bensofficial requested review from Mtze and Hialus November 27, 2023 13:06
@bensofficial bensofficial self-assigned this Nov 27, 2023
Copy link
Contributor

@kliwniloc kliwniloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to support the use case of having another separate SSL certificates for the old and the new domains. You could set the existing certificate as the default for both.

roles/proxy/templates/nginx_artemis.conf.j2 Show resolved Hide resolved
@kliwniloc
Copy link
Contributor

Furthermore, I recommend moving common SSL parameters into a distinct file to keep it maintainable. For guidance, consult the NGINX include documentation or review a practical tutorial by Digital Ocean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request role.proxy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants