Development: Add Theia configuration
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensofficial
requested changes
May 28, 2024
bensofficial
changed the title
Development: Add Theia configuration
bensofficial
previously approved these changes
Jun 7, 2024
Mtze
previously approved these changes
Jun 11, 2024
bensofficial
approved these changes
Jun 13, 2024
|
What's the status on this PR, can I close it or do you want to officially merge it? @bensofficial |
Mtze
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements changes requested by the ITG in this issue.
Currently, the ongoing integration of Theia into Artemis requires some new configuration values. This PR adds the
theia_base_urlto prod and env templates and the defaults.@Hialus are the changes in
artemis.env.j2sufficient or are there other changes necessary in some, e.g., Dockerfile?