-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkstyle and PMD report parsing #9
Conversation
…-checkstyle-and-pmd # Conflicts: # pom.xml # src/main/java/de/tum/in/www1/bamboo/server/ServerNotificationTransport.java
src/main/java/de/tum/in/www1/bamboo/server/parser/strategy/PMDParser.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/bamboo/server/parser/strategy/CheckstyleParser.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/bamboo/server/ServerNotificationTransport.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/bamboo/server/ServerNotificationTransport.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/bamboo/server/ServerNotificationTransport.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, works fine 👍
…ine or endColumn will be set.
src/main/java/de/tum/in/www1/bamboo/server/parser/strategy/ParserUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, I only found one issue, see my inline comment.
I wonder if we should add some automatic tests that could be executed using GitHub actions. I think this would really help in the future!
Motivation and Context
This PR extends the parsing functionality for static code analysis reports.
Description
Steps for Testing
ResultResource.notifyNewResult
--> Static Code Analysis reports should be part of the request body and should match the format defined in the notification plugin readme.