Implement external LS support #47
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the capability to run language servers in separate, dedicated containers, rather than inside the Theia container. This change introduces a new class to encapsulate the logic for creating and managing language server resources (Deployments and Services). Both the Eager and Lazy session handlers have been refactored to use this new utility, ensuring consistent behavior and reducing code duplication. The language server container image and ports are now configurable via the AppDefinition, making the system more flexible. The Kubernetes templates for the language server have also been updated to support dynamic port configuration. This lays the groundwork for a more scalable and maintainable architecture where language servers are decoupled from the IDE container.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…S sidecars, and fix OAuth2 secret length
This reverts commit 870fefb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made modifications to the operator so it spawns a Language server when a theia session without ls is being started