-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to mamico plugin after mamico refactor #293
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: FG-TUM <FG-TUM@users.noreply.github.com>
Seems not compatible with current MaMiCo master:
And also on the MaMiCo side:
|
The problem is that a bunch of these commits now depend on each other. Mamico master only works with the reflective-boundaries branch on ls1, which I didn't want to merge until I got this current PR merged, and pulled into reflective-boundaries. And on mamico side, the irregular domain decomp needs some bugfixing, and since the getSubdomainWeights() function is part of that, pushing that on master right now would mean there's code on master that technically doesn't work. I guess I can finish and merge irreg-dd-fix first before merging this, then mamico master will work with reflective-boundaries atleast. |
@cniethammer could you please check this PR? |
Description
After the mamico coding week, some files and functions were renamed. The plugin is now fixed to use these new names.
Fixes Issue #290