Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to mamico plugin after mamico refactor #293

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

amartyads
Copy link
Contributor

@amartyads amartyads commented Feb 26, 2024

Description

After the mamico coding week, some files and functions were renamed. The plugin is now fixed to use these new names.

Fixes Issue #290

src/plugins/MamicoCoupling.cpp Outdated Show resolved Hide resolved
src/plugins/MamicoCoupling.h Show resolved Hide resolved
src/plugins/MamicoCoupling.h Outdated Show resolved Hide resolved
src/plugins/MamicoCoupling.cpp Outdated Show resolved Hide resolved
src/plugins/MamicoCoupling.h Outdated Show resolved Hide resolved
src/plugins/MamicoCoupling.h Outdated Show resolved Hide resolved
src/plugins/MamicoCoupling.h Outdated Show resolved Hide resolved
src/plugins/MamicoCoupling.h Outdated Show resolved Hide resolved
src/plugins/MamicoCoupling.h Outdated Show resolved Hide resolved
src/plugins/MamicoCoupling.cpp Outdated Show resolved Hide resolved
amartyads and others added 2 commits February 26, 2024 13:51
Co-authored-by: FG-TUM <FG-TUM@users.noreply.github.com>
@amartyads amartyads marked this pull request as draft February 26, 2024 12:56
@amartyads
Copy link
Contributor Author

Since this fixes issue #290, which can only be done after the PR MaMiCo 45 is merged, I've turned this into draft.

@amartyads amartyads marked this pull request as ready for review August 9, 2024 08:19
FG-TUM
FG-TUM previously approved these changes Aug 9, 2024
@rubenhorn
Copy link
Contributor

rubenhorn commented Aug 13, 2024

Seems not compatible with current MaMiCo master:

MaMiCo/ls1/src/Simulation.cpp: In member function ‘void Simulation::readXML(XMLfileUnits&)’:
MaMiCo/ls1/src/Simulation.cpp:321:87: error: ‘class coupling::interface::LS1StaticCommData’ has no member named ‘getSubdomainWeights’
  321 |                                 coupling::interface::LS1StaticCommData::getInstance().getSubdomainWeights()
      |                                                                                       ^~~~~~~~~~~~~~~~~~~

And also on the MaMiCo side:

MaMiCo/coupling/interface/impl/ls1/LS1MDSolverInterface.h: In member function ‘virtual void coupling::interface::LS1MDSolverInterface::synchronizeMoleculesAfterMassModification()’:
MaMiCo/coupling/interface/impl/ls1/LS1MDSolverInterface.h:189:46: error: ‘class DomainDecompBase’ has no member named ‘removeNonPeriodicHalos’
  189 |     global_simulation->domainDecomposition().removeNonPeriodicHalos();
      |                                              ^~~~~~~~~~~~~~~~~~~~~~

@amartyads
Copy link
Contributor Author

The problem is that a bunch of these commits now depend on each other. Mamico master only works with the reflective-boundaries branch on ls1, which I didn't want to merge until I got this current PR merged, and pulled into reflective-boundaries.

And on mamico side, the irregular domain decomp needs some bugfixing, and since the getSubdomainWeights() function is part of that, pushing that on master right now would mean there's code on master that technically doesn't work.

I guess I can finish and merge irreg-dd-fix first before merging this, then mamico master will work with reflective-boundaries atleast.

@amartyads
Copy link
Contributor Author

@cniethammer could you please check this PR?

@amartyads amartyads linked an issue Sep 10, 2024 that may be closed by this pull request
@amartyads amartyads changed the base branch from master to reflective-boundaries September 10, 2024 13:50
@amartyads amartyads changed the base branch from reflective-boundaries to master September 10, 2024 13:51
@amartyads amartyads dismissed FG-TUM’s stale review September 10, 2024 13:51

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix MaMiCo Plugin (MaMiCo refactoring February 2024)
4 participants