Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Communication Classes #338

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Refactor Communication Classes #338

wants to merge 16 commits into from

Commits on Sep 4, 2024

  1. const and replace outdated todo by comment

    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f2bb5be View commit details
    Browse the repository at this point in the history

  2. Change log level from info to debug for low level information

    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c8b3034 View commit details
    Browse the repository at this point in the history

  3. Reorder cases based on likelihood to avoid unnecessary dynamic casts

    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    84dbe7a View commit details
    Browse the repository at this point in the history

  4. fix incomplete output

    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    65a0ce1 View commit details
    Browse the repository at this point in the history

  5. Refactor getCoversWholeDomain to return const reference

    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0fa3e00 View commit details
    Browse the repository at this point in the history

  6. rename GeneralDomainDecomposition::gridSize -> _latchGridSize for cla… 

    …rity
    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0cfabdd View commit details
    Browse the repository at this point in the history

  7. Refactor ALLLoadBalancer constructor to use const references 

    Updated ALLLoadBalancer constructor parameters to use `const` references for efficiency and alignment with expected input types for the ALL library. This change improves code clarity and ensures proper handling of input arguments by maintaining consistency in data types.
    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    39d51ba View commit details
    Browse the repository at this point in the history

  8. fix automatic grid size calculation

    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8b42919 View commit details
    Browse the repository at this point in the history

  9. use non-flushing linebreaks

    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    117ac00 View commit details
    Browse the repository at this point in the history

  10. const, rename for clarity and use std::array instead of pointer where… 

    … possible
    @FG-TUM
    FG-TUM committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    47180f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Refactor NeighborAcquirer.cpp for readability and efficiency 

      - const
  - constexpr
  - rename variables
  - move declarations to usages
  - limit scope
  - reserve before push_back
    @FG-TUM
    FG-TUM committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    46dc52c View commit details
    Browse the repository at this point in the history

  2. change low level info logs to debug

    @FG-TUM
    FG-TUM committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    da8e980 View commit details
    Browse the repository at this point in the history

  3. const + default inits + comments

    @FG-TUM
    FG-TUM committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3d8dab7 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Reserve the correct subvector of sendingList + clarify doc

    @FG-TUM
    FG-TUM committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c317648 View commit details
    Browse the repository at this point in the history

  2. formatting

    @FG-TUM
    FG-TUM committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0bb2a7c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'master' into fixgdd

    @FG-TUM
    FG-TUM committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1918b5d View commit details
    Browse the repository at this point in the history