Conversation
mjansenDatabay
requested changes
May 30, 2022
Collaborator
There was a problem hiding this comment.
Thx @lscharmer
I added some inline comments.
And: Please refactor the single methods added here by extracting them to a new class. The name of this class should represent the purpose of these access checks here (to check wether an actor has access to submitted filles of a learner for a File Upload Question).
lscharmer
force-pushed
the
hotfix/wac_assessment
branch
from
2183aa5 to
d9ac1f6
Compare
mjansenDatabay
requested changes
May 30, 2022
lscharmer
force-pushed
the
hotfix/wac_assessment
branch
from
d9ac1f6 to
6ac8ab4
Compare
mjansenDatabay
approved these changes
May 31, 2022
lscharmer
pushed a commit
that referenced
this pull request
May 31, 2022
Hi Fabian, a PHP Fatal Error occurs when performing setup command 'migrate': PHP Fatal error: Uncaught ILIAS\Setup\UnachievableException: Problem in DB-Update: 0 Return value of ilStaticCache::set() must be of the type bool, array returned in /***/trunk8/Services/GlobalCache/classes/Static/class.ilStaticCache.php:33#0 /***/trunk8/Services/GlobalCache/classes/class.ilGlobalCache.php(307): ilStaticCache->set() #1 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(62): ilGlobalCache->set() #2 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(29): ilCachedLanguage->writeToCache() #3 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(107): ilCachedLanguage->__construct() #4 /***/trunk8/Services/Language/classes/class.ilLanguage.php(91): ilCachedLanguage::getInstance() #5 /***/trunk8/Services/Language/classes/class.ilLanguage.php(374): ilLanguage->__construct in /***/trunk8/Services/Database/classes/Setup/class.ilDatabaseUpdatedObjective.php on line 72
lscharmer
force-pushed
the
hotfix/wac_assessment
branch
from
6ac8ab4 to
91834c3
Compare
lscharmer
force-pushed
the
hotfix/wac_assessment
branch
from
91834c3 to
1b9fef3
Compare
lscharmer
pushed a commit
that referenced
this pull request
Jun 11, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
lscharmer
pushed a commit
that referenced
this pull request
Jun 24, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
lscharmer
pushed a commit
that referenced
this pull request
Jun 24, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: ILIAS-eLearning#9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 ILIAS-eLearning#8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 ILIAS-eLearning#7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 ILIAS-eLearning#6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
lscharmer
pushed a commit
that referenced
this pull request
Jun 10, 2025
…bernehmen * Get file from UploadDir * Get file from UploadDir / CS Fixes * Changes mentioned in PR 9641 (#5) * [FIX] use only one ActionProvider * [FIX] nullable parameters * Input validation for Upload-Folder imports --------- Co-authored-by: www-data <www-data@localhost> Co-authored-by: Fabian Schmid <fabian@sr.solutions>
lscharmer
pushed a commit
that referenced
this pull request
Jun 10, 2025
…bernehmen * Get file from UploadDir * Get file from UploadDir / CS Fixes * Changes mentioned in PR 9641 (#5) * [FIX] use only one ActionProvider * [FIX] nullable parameters * Input validation for Upload-Folder imports --------- Co-authored-by: www-data <www-data@localhost> Co-authored-by: Fabian Schmid <fabian@sr.solutions>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WAC check for the assessment file answers.
https://mantis.ilias.de/view.php?id=29087