DM-46049: Add a Slack webhook to notify on failure #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-46049
branch
from
b4fd874
to
082a84b
Compare
timj
approved these changes
Aug 29, 2024
.github/workflows/lsst-tests.yml
Outdated
| @@ -60,3 +59,19 @@ jobs: | |||
| uses: codecov/codecov-action@v3 | |||
There was a problem hiding this comment.
You are going to want to update your codecov action to v4 and include the per-repo token (see daf_butler).
| - lsst-tests | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Slack Notification |
There was a problem hiding this comment.
I've never used this before so how does it know which channel to write to?
There was a problem hiding this comment.
I can add the app to any channel, or from the App management page I can add it to any channel.
|
Ignoring to review all the Python changes is fine. They are all from upstream and reviewed by Erin & Matt. |
arunkannawadi
force-pushed
the
tickets/DM-46049
branch
from
b742cf3
to
4d9c170
Compare
arunkannawadi
changed the base branch from
u/arunkannawadi/lsst-dev-sep3
to
lsst-dev
Co-authored-by: Tim Jenness <tim.jenness@gmail.com>
arunkannawadi
force-pushed
the
tickets/DM-46049
branch
from
4d9c170
to
be6335a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.