DM-43418: Divide AP pipeline into preload and prompt subsets #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Aug 28, 2024
kfindeisen
force-pushed
the
tickets/DM-43418
branch
2 times, most recently
from
975ef6a
to
8ebc14b
Compare
Using a stack for the cleanups reduces the number of nested blocks that need to be added to properly handle various objects, at the cost of one block for the stack itself. This lets try blocks be reserved purely for exception handling.
kfindeisen
force-pushed
the
tickets/DM-43418
branch
from
8ebc14b
to
3146486
Compare
This fixes a bug where the preprocessing runs would not be cleaned up if the service timed out while waiting for raws.
kfindeisen
force-pushed
the
tickets/DM-43418
branch
from
5c85b90
to
55cc31b
Compare
isullivan
approved these changes
Sep 4, 2024
The two subsets will now be run separately. There is also an "afterburner" subset, but it will not be run by Prompt Processing at all.
kfindeisen
force-pushed
the
tickets/DM-43418
branch
from
55cc31b
to
676520d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the pipeline files into separate pipelines, corresponding to the
promptandpreloadsubsets from lsst/ap_pipe#191.This pipeline needs to be tested after a daily is built with lsst/ap_pipe#191.