feat: galleries in search page #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgoff
commented
Jan 13, 2025
| @@ -107,7 +106,6 @@ const sectionMap = { | |||
| events: EventPageTemplate, | |||
| glossaryTerms: GlossaryPageTemplate, | |||
| news: NewsPageTemplate, | |||
| searchResults: SearchPageTemplate, | |||
There was a problem hiding this comment.
remove from catch-all
app/[locale]/search/page.tsx
Outdated
There was a problem hiding this comment.
implements what was previously the SearchPageTemplate as a static route
| return entry.id ? ( | ||
| <Tile | ||
| key={entry.id} | ||
| image={entry.image?.[0]} | ||
| image={ |
There was a problem hiding this comment.
show Canto assets in search results if available
| uri | ||
| } | ||
| const query = gql` | ||
| query getEntriesBySite($site: [String], $level: Int) { |
There was a problem hiding this comment.
since search pages aren't part of the catchall route anymore, they don't need to be part of it's static params generation
ericdrosas87
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add galleries to the search results page.
Includes refactor to the page itself. Previously it was a template served through the
[..uriSegments]catch-all. I think that did not make sense for a one-off page that would always live at the same route/search. I separated the search page into it's own static route so now the other pages don't bundle search code and search doesn't bundle code for other pages.