Skip to content

Conversation

@dtapiacl
Copy link
Contributor

@dtapiacl dtapiacl commented Dec 4, 2025

@dtapiacl dtapiacl requested a review from a team December 4, 2025 13:31
@dtapiacl dtapiacl self-assigned this Dec 4, 2025
@dtapiacl dtapiacl added the enhancement New feature or request label Dec 4, 2025
Copy link
Contributor

@gseriche gseriche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtapiacl dtapiacl force-pushed the IT-6536_update_bucket_notifications branch from ac92a98 to 6c8bc73 Compare December 4, 2025 13:38
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used this feature but per:

 ~ $ k explain CephBucketNotification.spec.filter.keyFilters
GROUP:      ceph.rook.io
KIND:       CephBucketNotification
VERSION:    v1

FIELD: keyFilters <[]Object>

DESCRIPTION:
    Filters based on the object's key
    NotificationKeyFilterRule represent a single key rule in the Notification
    Filter spec
    
FIELDS:
  name	<string> -required-
    Name of the filter - prefix/suffix/regex

  value	<string> -required-
    Value to filter on


this looks plausible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants