Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45965: cm-service: remove arq/redis #3637

Merged
merged 1 commit into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions applications/cm-service/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,3 @@ sources:
- https://github.com/lsst-dm/cm-service
type: application
version: 1.0.0

dependencies:
- name: redis
version: 1.0.13
repository: https://lsst-sqre.github.io/charts/
2 changes: 0 additions & 2 deletions applications/cm-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ Campaign Management for Rubin Data Release Production
| image.repository | string | `"ghcr.io/lsst-dm/cm-service"` | Image to use for frontend containers |
| image.tag | string | The appVersion of the chart | Tag of frontend image to use |
| ingress.annotations | object | `{}` | Additional annotations for the frontend ingress rule |
| redis.config.secretKey | string | `"password"` | Key inside secret from which to get the Redis password (do not change) |
| redis.config.secretName | string | `"redis-secret"` | Name of secret containing Redis password |
| worker.affinity | object | `{}` | Affinity rules for the worker pods |
| worker.htcondor.config.contents | string | `nil` | If specified, contents of htcondor config file to be injected into worker containers |
| worker.htcondor.config.mountPath | string | `nil` | If specified, location for htcondor config file to be injected into worker containers |
Expand Down
14 changes: 3 additions & 11 deletions applications/cm-service/secrets.yaml
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
redis-password:
description: >-
Password used to authenticate cm-service to its internal Redis server,
deployed as part of the same Argo CD application. This secret can be
changed at any time, but both the Redis server and the cm-service
deployments will then have to be restarted to pick up the new value.
generate:
type: password
postgres-password:
description: >-
Password used to authenticate cm-service to its internal cnpg Postgres
server, deployed as part of the same Argo CD application. This secret can
be changed at any time, but both the Redis server and the cm-service
deployments will then have to be restarted to pick up the new value.
server, deployed as part of the same Argo CD application. This secret can be
changed at any time, but the cm-service deployments will then have to be
restarted to pick up the new value.
generate:
type: password
7 changes: 0 additions & 7 deletions applications/cm-service/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ spec:
containers:
- name: "cm-service"
env:
- name: CM_ARQ_REDIS_PASSWORD
valueFrom:
secretKeyRef:
name: redis-secret
key: password
- name: CM_DATABASE_PASSWORD
valueFrom:
secretKeyRef:
Expand All @@ -48,8 +43,6 @@ spec:
value: {{ .Values.config.logProfile | quote }}
- name: CM_LOG_LEVEL
value: {{ .Values.config.logLevel | quote }}
- name: CM_ARQ_REDIS_URL
value: "redis://cm-service-redis/1"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
Expand Down
13 changes: 0 additions & 13 deletions applications/cm-service/templates/vault-secrets.yaml
Original file line number Diff line number Diff line change
@@ -1,18 +1,5 @@
apiVersion: ricoberger.de/v1alpha1
kind: VaultSecret
metadata:
name: redis-secret
labels:
{{- include "cm-service.labels" . | nindent 4 }}
spec:
path: "{{ .Values.global.vaultSecretsPath }}/cm-service"
templates:
password: >-
{% index .Secrets "redis-password" %}
type: Opaque
---
apiVersion: ricoberger.de/v1alpha1
kind: VaultSecret
metadata:
name: postgres-secret
labels:
Expand Down
8 changes: 0 additions & 8 deletions applications/cm-service/templates/worker-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,6 @@ spec:
automountServiceAccountToken: false
containers:
- name: "cm-service-worker"
env:
- name: CM_ARQ_REDIS_PASSWORD
valueFrom:
secretKeyRef:
name: redis-secret
key: password
- name: CM_ARQ_REDIS_URL
value: "redis://cm-service-redis/1"
image: "{{ .Values.worker.image.repository }}:{{ .Values.worker.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
resources:
Expand Down
9 changes: 0 additions & 9 deletions applications/cm-service/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,6 @@ worker:
# -- If specified, location for htcondor schedd address file to be injected into worker pods
contents: null

redis:
config:
# -- Name of secret containing Redis password
secretName: "redis-secret"

# -- Key inside secret from which to get the Redis password (do not
# change)
secretKey: "password"

# The following will be set by parameters injected by Argo CD and should not
# be set in the individual environment values files.
global:
Expand Down
Loading